Do not allocate MemorySegments for memory.data(i32, i32?)#2831
Open
CountBleck wants to merge 1 commit intoAssemblyScript:mainfrom
Open
Do not allocate MemorySegments for memory.data(i32, i32?)#2831CountBleck wants to merge 1 commit intoAssemblyScript:mainfrom
CountBleck wants to merge 1 commit intoAssemblyScript:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2827.
Changes proposed in this pull request:
⯈ Bump
Compiler#memoryOffsetinstead of allocating zero-filled segments.There is an issue with the
initialPagescalculation ininitDefaultMemory, however. The existing condition to run that calculation depends onmemorySegments.length, which is now zero if onlymemory.data(n: i32)is called, as in the memory-config-errors test.Making that calculation occur regardless of the number of memory segments would cause a separate issue: due to the default memory offsets of
options.memoryBase,1024, or8, modules that previously compiled with an initial memory of 0 pages would compile with a minimum of 1 page.